Skip to content

refactor: ECHO-415: Revert "BEM Migration in editor" #8688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor: ECHO-415: Revert "BEM Migration in editor" #8688

wants to merge 1 commit into from

Conversation

@luarmr
Copy link
Contributor

@luarmr luarmr commented Oct 22, 2025

Reverts #8660

Just in case

@luarmr luarmr requested review from a team, hlomzik and nick-skriabin as code owners October 22, 2025 18:47
@netlify
Copy link

netlify bot commented Oct 22, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit ab169bf
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68f926c4f916c1000895851f

@netlify
Copy link

netlify bot commented Oct 22, 2025 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit ab169bf
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68f926c4f4794f00089aae87

@netlify
Copy link

netlify bot commented Oct 22, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit ab169bf
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68f926c4afc9eb0008751e0e

yyassi-heartex
yyassi-heartex approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully we won't need it

@netlify
Copy link

netlify bot commented Oct 22, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit ab169bf
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68f926c40014d00008af5204

@codecov
Copy link

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.44828% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.05%. Comparing base (eda02c5) to head (ab169bf).
⚠️ Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
web/libs/editor/src/common/Button/Button.tsx 0.00% 6 Missing ⚠️
web/libs/editor/src/common/Range/Range.tsx 60.00% 2 Missing ⚠️
.../src/components/AnnotationTab/AutoAcceptToggle.jsx 0.00% 2 Missing ⚠️
...src/components/CurrentEntity/AnnotationHistory.tsx 80.00% 2 Missing ⚠️
...omponents/SidePanels/DetailsPanel/DetailsPanel.tsx 0.00% 2 Missing ⚠️
...src/components/Timeline/Controls/ConfigControl.tsx 33.33% 2 Missing ⚠️
...b/libs/editor/src/common/Pagination/Pagination.tsx 50.00% 1 Missing ⚠️
...bs/editor/src/components/BottomBar/CurrentTask.jsx 66.66% 1 Missing ⚠️
web/libs/editor/src/components/ImageView/Image.jsx 0.00% 1 Missing ⚠️
...omponents/Timeline/Controls/SpectrogramControl.tsx 0.00% 1 Missing ⚠️
... and 4 more

❗ There is a different number of reports uploaded between BASE (eda02c5) and HEAD (ab169bf). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (eda02c5) HEAD (ab169bf)
pytests 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8688      +/-   ##
===========================================
- Coverage    67.04%   60.05%   -7.00%     
===========================================
  Files          791      554     -237     
  Lines        60451    38895   -21556     
  Branches     10305    10291      -14     
===========================================
- Hits         40531    23359   -17172     
+ Misses       19917    15533    -4384     
  Partials         3        3
Flag Coverage Δ
lsf-e2e 54.34% <76.59%> (+<0.01%) ⬆️
lsf-integration 50.76% <73.75%> (+<0.01%) ⬆️
lsf-unit 8.39% <9.25%> (+<0.01%) ⬆️
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luarmr luarmr closed this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yyassi-heartex yyassi-heartex yyassi-heartex approved these changes

@hlomzik hlomzik Awaiting requested review from hlomzik hlomzik is a code owner

@nick-skriabin nick-skriabin Awaiting requested review from nick-skriabin nick-skriabin is a code owner

Assignees

No one assigned

Labels

refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luarmr @yyassi-heartex